fix(follower): add experimental tag to deltas endpoint.#5169
Merged
Conversation
winder
force-pushed
the
will/deltas-endpoint-tag
branch
from
f8baa2c to
02bc56e
Compare
Codecov Report
@@ Coverage Diff @@
## master #5169 +/- ##
==========================================
- Coverage 53.58% 46.33% -7.25%
==========================================
Files 439 439
Lines 54934 54934
==========================================
- Hits 29434 25455 -3979
- Misses 23214 27110 +3896
- Partials 2286 2369 +83
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Eric-Warehime
approved these changes
Feb 28, 2023
Comment on lines
+8
to
+9
| # do not include endpoints tagged public/experimental | ||
| # - public |
Contributor
There was a problem hiding this comment.
This works, but it's a bit hacky because the tags weren't meant to be overlapping like this--each set of APIs, gated by certain configs, is tagged as public or private to identify the authenticator required, and a single category.
This will introduce partially overlapping sets of tags in ways that could become messy in the future. But it does look like the only viable way we currently have to disable sdk code gen for an API w/o requiring the admin token.
shiqizng
approved these changes
Feb 28, 2023
This was referenced Mar 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The deltas endpoint is currently intended for internal use by Conduit. This PR adds the experimental tag to the endpoint in order to avoid including it in generated SDK code.
Test Plan
No functional changes.