refactor: Move streamVerifier to util/execpool/stream (phase 2)#5168
Merged
algorandskiy merged 5 commits intoalgorand:masterfrom Mar 13, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5168 +/- ##
==========================================
+ Coverage 53.51% 53.57% +0.06%
==========================================
Files 439 441 +2
Lines 54985 55065 +80
==========================================
+ Hits 29423 29499 +76
- Misses 23271 23281 +10
+ Partials 2291 2285 -6
... and 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…y_votes_phase2_wt_tests
Contributor
algorandskiy
left a comment
algorandskiy
left a comment
There was a problem hiding this comment.
LGTM, indeed a code move and test
algorandskiy
approved these changes
Mar 12, 2023
iansuvak
approved these changes
Mar 13, 2023
Contributor
iansuvak
left a comment
iansuvak
left a comment
There was a problem hiding this comment.
Both tests and code-move look good
algorandskiy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move streamVerifier to util/execpool
Add utint tests to util/execpool/stream
update the call sites to this interface