feat(algocfg): add development profile and profile descriptions.#5164
Merged
winder merged 6 commits intoalgorand:masterfrom Mar 10, 2023
Merged
feat(algocfg): add development profile and profile descriptions.#5164winder merged 6 commits intoalgorand:masterfrom
winder merged 6 commits intoalgorand:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5164 +/- ##
==========================================
- Coverage 53.63% 53.59% -0.04%
==========================================
Files 437 437
Lines 54934 54947 +13
==========================================
- Hits 29463 29451 -12
- Misses 23191 23210 +19
- Partials 2280 2286 +6
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
shiqizng
reviewed
Mar 6, 2023
shiqizng
previously approved these changes
Mar 6, 2023
Comment on lines
+63
to
+64
| cfg.MaxAcctLookback = 16 | ||
| cfg.CatchupParallelBlocks = 16 |
Contributor
There was a problem hiding this comment.
In our perf tests, I've been using the following:
cfg.CatchupParallelBlocks = 64
cfg.EnableFollowMode = true
cfg.MaxAcctLookback = 64
Also worth noting that the test script sets
cfg. CatchupBlockValidateMode = 3
which will probably speed up catchup, but has some trust implications obviously.
jsgranados
reviewed
Mar 9, 2023
jsgranados
reviewed
Mar 9, 2023
jsgranados
reviewed
Mar 9, 2023
onetechnical
approved these changes
Mar 10, 2023
Contributor
onetechnical
left a comment
There was a problem hiding this comment.
PR description no longer matches, but seems good otherwise.
shiqizng
approved these changes
Mar 10, 2023
This was referenced Mar 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update
algocfg profilecommand:listsubcommand.Descriptions:
Documentation