Skip to content

tests: fix debug output in expect test harness#5158

Merged
algorandskiy merged 1 commit into
algorand:masterfrom
algorandskiy:pavel/expect-test-logs-4
Feb 24, 2023
Merged

tests: fix debug output in expect test harness#5158
algorandskiy merged 1 commit into
algorand:masterfrom
algorandskiy:pavel/expect-test-logs-4

Conversation

@algorandskiy
Copy link
Copy Markdown
Contributor

Summary

The original implementation had scoping issue with tcp_platform global var as this build indicated.
Additionally added stdout redirect for exec since its behavior in a script differs from REPL where I tested the original code.

Test Plan

This is a test harness change.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 24, 2023

Codecov Report

Merging #5158 (81fa781) into master (8bb071f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5158   +/-   ##
=======================================
  Coverage   53.57%   53.57%           
=======================================
  Files         434      434           
  Lines       54748    54748           
=======================================
  Hits        29333    29333           
- Misses      23131    23133    +2     
+ Partials     2284     2282    -2     
Impacted Files Coverage Δ
ledger/tracker.go 72.91% <0.00%> (-3.75%) ⬇️
ledger/acctupdates.go 68.53% <0.00%> (-0.48%) ⬇️
catchup/service.go 70.82% <0.00%> (-0.24%) ⬇️
network/wsNetwork.go 69.14% <0.00%> (-0.18%) ⬇️
ledger/testing/randomAccounts.go 56.26% <0.00%> (ø)
network/wsPeer.go 71.95% <0.00%> (+2.52%) ⬆️
ledger/blockqueue.go 84.94% <0.00%> (+2.68%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Copy Markdown
Contributor

@bbroder-algo bbroder-algo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

Copy link
Copy Markdown
Contributor

@algonautshant algonautshant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@algorandskiy algorandskiy merged commit 292b807 into algorand:master Feb 24, 2023
@algorandskiy algorandskiy deleted the pavel/expect-test-logs-4 branch March 16, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants