node: Fix time since last block.#5113
Merged
Merged
Conversation
Contributor
Eric-Warehime
left a comment
Eric-Warehime
left a comment
There was a problem hiding this comment.
LGTM once your test passes.
Codecov Report
@@ Coverage Diff @@
## master #5113 +/- ##
==========================================
+ Coverage 53.42% 53.43% +0.01%
==========================================
Files 431 431
Lines 54369 54381 +12
==========================================
+ Hits 29046 29058 +12
- Misses 23061 23066 +5
+ Partials 2262 2257 -5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algojack
approved these changes
Feb 6, 2023
Contributor
algojack
left a comment
algojack
left a comment
There was a problem hiding this comment.
lgtm, thanks for fixing it.
This was referenced Mar 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We started skipping the last round timestamp and synced since timestamp with a recent change.
Test Plan
New e2e test.