goal: fix for goal node status crash - no longer getting block#5100
Merged
winder merged 1 commit intoalgorand:masterfrom Feb 2, 2023
Merged
goal: fix for goal node status crash - no longer getting block#5100winder merged 1 commit intoalgorand:masterfrom
winder merged 1 commit intoalgorand:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5100 +/- ##
==========================================
- Coverage 53.48% 53.47% -0.01%
==========================================
Files 429 429
Lines 54041 54037 -4
==========================================
- Hits 28905 28898 -7
+ Misses 22890 22889 -1
- Partials 2246 2250 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mciccarello
changed the title
winder
approved these changes
Feb 2, 2023
Contributor
winder
left a comment
winder
left a comment
There was a problem hiding this comment.
I ran some manual tests and this seems to work fine.
winder
changed the title
algolucky
pushed a commit
to algolucky/go-algorand
that referenced
this pull request
Feb 2, 2023
This was referenced Mar 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid extra call to
ledger.BlockHdr. It is unnecessary and seemed to lead to a crash in some edge cases.