Skip to content

API: Incorrect KvDelta in StateDeltaToLedgerDelta #5084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
winder merged 1 commit into from
Feb 2, 2023
Merged

API: Incorrect KvDelta in StateDeltaToLedgerDelta #5084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion daemon/algod/api/server/v2/delta.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,10 @@ func StateDeltaToLedgerDelta(sDelta ledgercore.StateDelta, consensus config.Cons

for key, kvDelta := range sDelta.KvMods {
var keyBytes = []byte(key)
var valueBytes = kvDelta.Data
keyValues = append(keyValues, model.KvDelta{
Key: &keyBytes,
Value: &kvDelta.Data,
Value: &valueBytes,
})
}

Expand Down
10 changes: 10 additions & 0 deletions daemon/algod/api/server/v2/delta_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,12 @@ func TestDelta(t *testing.T) {
Data: []byte("foobar"),
OldData: []byte("barfoo"),
},
"box2": {
Data: []byte("alpha"),
},
"box3": {
Data: []byte("beta"),
},
},
Txleases: map[ledgercore.Txlease]basics.Round{
{Sender: poolAddr, Lease: txLease}: 600,
Expand Down Expand Up @@ -134,6 +140,10 @@ func TestDelta(t *testing.T) {
require.Equal(t, len(original.KvMods), len(*converted.KvMods))
require.Equal(t, []uint8("box1"), *(*converted.KvMods)[0].Key)
require.Equal(t, original.KvMods["box1"].Data, *(*converted.KvMods)[0].Value)
require.Equal(t, []uint8("box2"), *(*converted.KvMods)[1].Key)
require.Equal(t, original.KvMods["box2"].Data, *(*converted.KvMods)[1].Value)
require.Equal(t, []uint8("box3"), *(*converted.KvMods)[2].Key)
require.Equal(t, original.KvMods["box3"].Data, *(*converted.KvMods)[2].Value)
require.Equal(t, txLease[:], (*converted.TxLeases)[0].Lease)
require.Equal(t, poolAddr.String(), (*converted.TxLeases)[0].Sender)
require.Equal(t, uint64(600), (*converted.TxLeases)[0].Expiration)
Expand Down