Skip to content

tests: add more logging to expect test#5078

Merged
algorandskiy merged 1 commit into
algorand:masterfrom
algorandskiy:pavel/expect-test-logs-2
Jan 30, 2023
Merged

tests: add more logging to expect test#5078
algorandskiy merged 1 commit into
algorand:masterfrom
algorandskiy:pavel/expect-test-logs-2

Conversation

@algorandskiy
Copy link
Copy Markdown
Contributor

Summary

More kmd logging in expect test runner to diagnose sporadic expect test failures.
Added "goal account import key" logging in net template code to diagnose "Error creating private network: exit status 1" errors.

Test Plan

This is test-related code

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 30, 2023

Codecov Report

Merging #5078 (ce09e9f) into master (1ad3db9) will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #5078      +/-   ##
==========================================
+ Coverage   53.57%   53.60%   +0.03%     
==========================================
  Files         430      430              
  Lines       54091    54093       +2     
==========================================
+ Hits        28980    28998      +18     
+ Misses      22864    22853      -11     
+ Partials     2247     2242       -5     
Impacted Files Coverage Δ
netdeploy/networkTemplate.go 29.05% <0.00%> (-0.51%) ⬇️
ledger/acctupdates.go 68.99% <0.00%> (-0.25%) ⬇️
catchup/service.go 69.80% <0.00%> (ø)
ledger/catchpointtracker.go 58.49% <0.00%> (ø)
data/transactions/logic/assembler.go 87.25% <0.00%> (+0.13%) ⬆️
network/wsNetwork.go 64.92% <0.00%> (+0.17%) ⬆️
ledger/testing/randomAccounts.go 56.88% <0.00%> (+0.61%) ⬆️
catchup/peerSelector.go 100.00% <0.00%> (+1.04%) ⬆️
agreement/proposalManager.go 98.03% <0.00%> (+1.96%) ⬆️
agreement/cryptoVerifier.go 69.71% <0.00%> (+2.11%) ⬆️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Copy Markdown
Contributor

@algonautshant algonautshant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looksfine.

@algorandskiy algorandskiy merged commit c8b5deb into algorand:master Jan 30, 2023
@algorandskiy algorandskiy deleted the pavel/expect-test-logs-2 branch March 16, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants