goal: allow for relative dataDir via -d cmd option#5067
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5067 +/- ##
==========================================
+ Coverage 53.56% 53.58% +0.02%
==========================================
Files 430 430
Lines 54091 54094 +3
==========================================
+ Hits 28972 28985 +13
+ Misses 22873 22860 -13
- Partials 2246 2249 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@algorandskiy , the Ci complains...
|
algorandskiy
left a comment
There was a problem hiding this comment.
I'd make resolveDataDir a function taking dirs as its argument, and update cmd/algocfg/datadir.go as well, and probably move it to cmd/utils. But this also LGTM
I did not notice the code-duplication, there are even more Would prefer to handle them in a separate follow-up issue/PR (see #5068).
Ty! (btw: fascinating fast PR processing!) |
|
closes #589 |
|
@algorandskiy , somehow the github auto-close-issue did not trigger, still open: #589 |
Post Merge Complaint
[COMPLAINT] Is the Algorand Inc. aware of the heavily dysfunctional Algorand Foundation?
Summary
Allow relative data-dir, as described within #589
Test Plan
existent tests pass, added some more tests
go test -v ./cmd/goalFollow-up
#5073