e2e tests: log pending transactions in case of failure#5062
Conversation
algorandskiy
added
tech debt
Codecov Report
@@ Coverage Diff @@
## master #5062 +/- ##
==========================================
+ Coverage 53.57% 53.60% +0.03%
==========================================
Files 430 430
Lines 54091 54091
==========================================
+ Hits 28979 28996 +17
+ Misses 22868 22851 -17
Partials 2244 2244
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algonautshant
left a comment
algonautshant
left a comment
There was a problem hiding this comment.
Great! thanks for doing this.
It is terrible some of these logging information was missing for so long.
| for _, txn := range pendingTxns.TopTransactions { | ||
| pendingTxids = append(pendingTxids, txn.Txn.ID().String()) | ||
| } | ||
| f.t.Logf("pending txids at node %s: %v", nodedir, pendingTxids) |
There was a problem hiding this comment.
This information might not always be relevant, also there could be so many of them depending on the test situation.
Is there a cap on the total number? Maybe limit it to some number so it won't print a huge number in some unlucky situation.
There was a problem hiding this comment.
our tests do not submit lots of txn, and in case of failure only few are expected to be still pending.
3 participants
Summary
Time to time some e2e tests fails on waiting for txn go get included into a block. This change adds more logging for such failures to ensure txns are at least propagated to all nodes.
Test Plan
This is a test fixture change.