Tests: No Cache Testing in ledger

config/localTemplate.go

@@ -493,6 +493,11 @@ type Local struct {
 	// guarantees in terms of functionality or future support.
 	EnableExperimentalAPI bool `version[26]:"false"`
 
+	// DisableLedgerLRUCache disables LRU caches in ledger.
+	// Setting it to TRUE might result in significant performance degradation
+	// and SHOULD NOT be used for other reasons than testing.
+	DisableLedgerLRUCache bool `version[27]:"false"`
+
 	// EnableFollowMode launches the node in "follower" mode. This turns off the agreement service,
 	// and APIs related to broadcasting transactions, and enables APIs which can retrieve detailed information
 	// from ledger caches and can control the ledger round.

config/local_defaults.go

@@ -49,6 +49,7 @@ var defaultLocal = Local{
 	DNSSecurityFlags:                           1,
 	DeadlockDetection:                          0,
 	DeadlockDetectionThreshold:                 30,
+	DisableLedgerLRUCache:                      false,
 	DisableLocalhostConnectionRateLimit:        true,
 	DisableNetworking:                          false,
 	DisableOutgoingConnectionThrottling:        false,

installer/config.json.example

@@ -28,6 +28,7 @@
     "DNSSecurityFlags": 1,
     "DeadlockDetection": 0,
     "DeadlockDetectionThreshold": 30,
+    "DisableLedgerLRUCache": false,
     "DisableLocalhostConnectionRateLimit": true,
     "DisableNetworking": false,
     "DisableOutgoingConnectionThrottling": false,

ledger/acctonline.go

@@ -117,12 +117,16 @@ type onlineAccounts struct {
 
 	// maxAcctLookback sets the minimim deltas size to keep in memory
 	acctLookback uint64
+
+	// disableCache (de)activates the LRU cache use in onlineAccounts
+	disableCache bool
 }
 
 // initialize initializes the accountUpdates structure
 func (ao *onlineAccounts) initialize(cfg config.Local) {
 	ao.accountsReadCond = sync.NewCond(ao.accountsMu.RLocker())
 	ao.acctLookback = cfg.MaxAcctLookback
+	ao.disableCache = cfg.DisableLedgerLRUCache
 }
 
 // loadFromDisk is the 2nd level initialization, and is required before the onlineAccounts becomes functional
@@ -184,7 +188,11 @@ func (ao *onlineAccounts) initializeFromDisk(l ledgerForTracker, lastBalancesRou
 	ao.accounts = make(map[basics.Address]modifiedOnlineAccount)
 	ao.deltasAccum = []int{0}
 
-	ao.baseOnlineAccounts.init(ao.log, baseAccountsPendingAccountsBufferSize, baseAccountsPendingAccountsWarnThreshold)
+	if !ao.disableCache {
+		ao.baseOnlineAccounts.init(ao.log, baseAccountsPendingAccountsBufferSize, baseAccountsPendingAccountsWarnThreshold)
+	} else {
+		ao.baseOnlineAccounts.init(ao.log, 0, 0)
+	}
 	return
 }
 

ledger/acctupdates.go

@@ -227,6 +227,9 @@ type accountUpdates struct {
 
 	// maxAcctLookback sets the minimim deltas size to keep in memory
 	acctLookback uint64
+
+	// disableCache (de)activates the LRU cache use in accountUpdates
+	disableCache bool
 }
 
 // RoundOffsetError is an error for when requested round is behind earliest stored db entry
@@ -296,6 +299,8 @@ func (au *accountUpdates) initialize(cfg config.Local) {
 	// log metrics
 	au.logAccountUpdatesMetrics = cfg.EnableAccountUpdatesStats
 	au.logAccountUpdatesInterval = cfg.AccountUpdatesStatsInterval
+
+	au.disableCache = cfg.DisableLedgerLRUCache
 }
 
 // loadFromDisk is the 2nd level initialization, and is required before the accountUpdates becomes functional
@@ -962,9 +967,15 @@ func (au *accountUpdates) initializeFromDisk(l ledgerForTracker, lastBalancesRou
 	au.creatables = make(map[basics.CreatableIndex]ledgercore.ModifiedCreatable)
 	au.deltasAccum = []int{0}
 
-	au.baseAccounts.init(au.log, baseAccountsPendingAccountsBufferSize, baseAccountsPendingAccountsWarnThreshold)
-	au.baseResources.init(au.log, baseResourcesPendingAccountsBufferSize, baseResourcesPendingAccountsWarnThreshold)
-	au.baseKVs.init(au.log, baseKVPendingBufferSize, baseKVPendingWarnThreshold)
+	if !au.disableCache {
+		au.baseAccounts.init(au.log, baseAccountsPendingAccountsBufferSize, baseAccountsPendingAccountsWarnThreshold)
+		au.baseResources.init(au.log, baseResourcesPendingAccountsBufferSize, baseResourcesPendingAccountsWarnThreshold)
+		au.baseKVs.init(au.log, baseKVPendingBufferSize, baseKVPendingWarnThreshold)
+	} else {
+		au.baseAccounts.init(au.log, 0, 0)
+		au.baseResources.init(au.log, 0, 0)
+		au.baseKVs.init(au.log, 0, 0)
+	}
 	return
 }
 

ledger/acctupdates_test.go

@@ -475,20 +475,13 @@ func checkOnlineAcctUpdatesConsistency(t *testing.T, ao *onlineAccounts, rnd bas
 	}
 }
 
-func TestAcctUpdates(t *testing.T) {
-	partitiontest.PartitionTest(t)
-
-	if runtime.GOARCH == "arm" || runtime.GOARCH == "arm64" {
-		t.Skip("This test is too slow on ARM and causes travis builds to time out")
-	}
-
+func testAcctUpdates(t *testing.T, conf config.Local) {
 	// The next operations are heavy on the memory.
 	// Garbage collection helps prevent trashing
 	runtime.GC()
 
 	proto := config.Consensus[protocol.ConsensusCurrentVersion]
 
-	conf := config.GetDefaultLocal()
 	for _, lookback := range []uint64{conf.MaxAcctLookback, proto.MaxBalLookback} {
 		t.Run(fmt.Sprintf("lookback=%d", lookback), func(t *testing.T) {
 
@@ -597,6 +590,13 @@ func TestAcctUpdates(t *testing.T) {
 	}
 }
 
+func TestAcctUpdates(t *testing.T) {
+	partitiontest.PartitionTest(t)
+
+	conf := config.GetDefaultLocal()
+	ledgertesting.WithAndWithoutLRUCache(t, conf, testAcctUpdates)
+}
+
 func BenchmarkBalancesChanges(b *testing.B) {
 	if runtime.GOARCH == "arm" || runtime.GOARCH == "arm64" {
 		b.Skip("This test is too slow on ARM and causes travis builds to time out")
@@ -712,20 +712,21 @@ func BenchmarkCalibrateCacheNodeSize(b *testing.B) {
 // The TestAcctUpdatesUpdatesCorrectness conduct a correctless test for the accounts update in the following way -
 // Each account is initialized with 100 algos.
 // On every round, each account move variable amount of funds to an accumulating account.
-// The deltas for each accounts are picked by using the lookup method.
+// The deltas for each account are picked by using the lookup method.
 // At the end of the test, we verify that each account has the expected amount of algos.
 // In addition, throughout the test, we check ( using lookup ) that the historical balances, *beyond* the
 // lookback are generating either an error, or returning the correct amount.
 func TestAcctUpdatesUpdatesCorrectness(t *testing.T) {
 	partitiontest.PartitionTest(t)
 
-	if runtime.GOARCH == "arm" || runtime.GOARCH == "arm64" {
-		t.Skip("This test is too slow on ARM and causes travis builds to time out")
-	}
+	cfgLocal := config.GetDefaultLocal()
+	ledgertesting.WithAndWithoutLRUCache(t, cfgLocal, testAcctUpdatesUpdatesCorrectness)
+}
 
+func testAcctUpdatesUpdatesCorrectness(t *testing.T, cfg config.Local) {
 	// create new protocol version, which has lower look back.
 	testProtocolVersion := protocol.ConsensusCurrentVersion
-	maxAcctLookback := config.GetDefaultLocal().MaxAcctLookback
+	maxAcctLookback := cfg.MaxAcctLookback
 	inMemory := true
 
 	testFunction := func(t *testing.T) {
@@ -750,8 +751,7 @@ func TestAcctUpdatesUpdatesCorrectness(t *testing.T) {
 			accts[0][addr] = accountData
 		}
 
-		conf := config.GetDefaultLocal()
-		au, _ := newAcctUpdates(t, ml, conf)
+		au, _ := newAcctUpdates(t, ml, cfg)
 		defer au.close()
 
 		// cover 10 genesis blocks