Skip to content

tests: disable TestInitialSync on CI #5053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
onetechnical merged 1 commit into from
Jan 25, 2023
Merged

tests: disable TestInitialSync on CI #5053

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions node/node_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ import (
"math/rand"
"os"
"path/filepath"
"runtime"
"strconv"
"strings"
Comment thread
algorandskiy marked this conversation as resolved.
Outdated
"sync"
"testing"
"time"
Expand Down Expand Up @@ -245,6 +247,11 @@ func TestInitialSync(t *testing.T) {
t.Skip("Test takes ~25 seconds.")
}

if (runtime.GOARCH == "arm" || runtime.GOARCH == "arm64") &&
strings.ToUpper(os.Getenv("CIRCLECI")) == "TRUE" {
t.Skip("Test is too heavy for amd64 builder running in parallel with other packages")
Copy link
Copy Markdown
Contributor

@cce cce Jan 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really running in parallel with other packages though? I thought we don't allow that

Copy link
Copy Markdown
Contributor Author

@algorandskiy algorandskiy Jan 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try make test and observe LA 100+ with all cores busy and 8+ test processes

Copy link
Copy Markdown
Contributor

@algonautshant algonautshant Jan 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is far as I know, tests do not run with others when t.Parallel() is not called.
That the the whole reason why we have multiple runs on CircleCi.

If we are running things in parallel, something has changed!

Copy link
Copy Markdown
Contributor Author

@algorandskiy algorandskiy Jan 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

t.Parallel() takes effect only within a single package (test binary)

Copy link
Copy Markdown
Contributor

@cce cce Jan 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we disable package-level parallelism in CI by passing -p 1 in the .circleci/confiig.yml file though

Copy link
Copy Markdown
Contributor Author

@algorandskiy algorandskiy Jan 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, I expected it calling make test. Then it is very weird it fails time to time

}

backlogPool := execpool.MakeBacklog(nil, 0, execpool.LowPriority, nil)
defer backlogPool.Shutdown()

Expand Down