build: update C++ flags for recent Mac compiler warnings#5050
Merged
Conversation
algorandskiy
approved these changes
Jan 24, 2023
Codecov Report
@@ Coverage Diff @@
## master #5050 +/- ##
==========================================
- Coverage 53.48% 53.47% -0.01%
==========================================
Files 429 429
Lines 54043 54043
==========================================
- Hits 28904 28899 -5
- Misses 22894 22896 +2
- Partials 2245 2248 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This was referenced Mar 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A recent release to the Mac C/C++ build tools have caused warnings about sprintf to appear when building the data/committee/sortition package while parsing a Boost header that uses sprintf. This silences those warnings, as our usage of Boost's boost::math::binomial_distribution should not invoke these sprintf calls.
Test Plan
Existing tests should pass