development: tool to convert validated blocks.#5048
Merged
Conversation
winder
commented
Jan 24, 2023
Comment on lines
+1086
to
+1087
| consensusParams := config.Consensus[sDelta.Hdr.CurrentProtocol] | ||
| response, err := StateDeltaToLedgerDelta(sDelta, consensusParams) |
Contributor
Author
There was a problem hiding this comment.
@Eric-Warehime do you happen to know if this simplification is valid? I can revert if you aren't sure.
Contributor
There was a problem hiding this comment.
Yeah it looks correct to me.
Line 263 in 2594c32
Codecov Report
@@ Coverage Diff @@
## master #5048 +/- ##
==========================================
+ Coverage 53.56% 53.59% +0.02%
==========================================
Files 430 430
Lines 54095 54092 -3
==========================================
+ Hits 28978 28989 +11
+ Misses 22869 22862 -7
+ Partials 2248 2241 -7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
shiqizng
approved these changes
Jan 24, 2023
This was referenced Mar 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Helper command to assist with converting files during development.