Skip to content

CICD: Adding github release notes template#5044

Merged
onetechnical merged 2 commits into
algorand:masterfrom
algojack:Adding-github-release-notes-template
Jan 25, 2023
Merged

CICD: Adding github release notes template#5044
onetechnical merged 2 commits into
algorand:masterfrom
algojack:Adding-github-release-notes-template

Conversation

@algojack
Copy link
Copy Markdown
Contributor

@algojack algojack commented Jan 23, 2023

in case we need it in future. copied from indexer repo

algolucky
algolucky previously approved these changes Jan 23, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 23, 2023

Codecov Report

Merging #5044 (04624f9) into master (b8866c9) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5044      +/-   ##
==========================================
- Coverage   53.50%   53.47%   -0.03%     
==========================================
  Files         429      429              
  Lines       54038    54038              
==========================================
- Hits        28911    28899      -12     
- Misses      22883    22895      +12     
  Partials     2244     2244              
Impacted Files Coverage Δ
network/wsPeer.go 66.43% <0.00%> (-2.13%) ⬇️
data/txHandler.go 70.87% <0.00%> (-1.21%) ⬇️
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) ⬇️
ledger/tracker.go 74.26% <0.00%> (-0.85%) ⬇️
ledger/testing/randomAccounts.go 56.26% <0.00%> (-0.62%) ⬇️
network/wsNetwork.go 64.74% <0.00%> (ø)
ledger/acctupdates.go 69.48% <0.00%> (+0.24%) ⬆️
catchup/service.go 69.80% <0.00%> (+1.20%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@algojack algojack changed the title Adding github release notes template CICD: Adding github release notes template Jan 23, 2023
Copy link
Copy Markdown
Contributor

@excalq excalq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you just want to rename the current .github/.release.yml. I'm surprised it's working with the extraneous . in the filename.

excalq
excalq previously requested changes Jan 24, 2023
Copy link
Copy Markdown
Contributor

@excalq excalq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if not a rename, nuke that .release.yml file so there isn't both.

@algojack
Copy link
Copy Markdown
Contributor Author

algojack commented Jan 25, 2023

Even if not a rename, nuke that .release.yml file so there isn't both.

it's a rename, didn't see it since it was with a dot. Good catch.

@algojack algojack requested a review from excalq January 25, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants