agreement: fix receivedAt proposal performance timing#5041
Merged
algorandskiy merged 3 commits intoalgorand:masterfrom Jan 23, 2023
Merged
agreement: fix receivedAt proposal performance timing#5041algorandskiy merged 3 commits intoalgorand:masterfrom
algorandskiy merged 3 commits intoalgorand:masterfrom
Conversation
brianolson
approved these changes
Jan 23, 2023
Contributor
brianolson
left a comment
brianolson
left a comment
There was a problem hiding this comment.
looks pretty simple
LGTM
algorandskiy
approved these changes
Jan 23, 2023
Contributor
algorandskiy
left a comment
algorandskiy
left a comment
There was a problem hiding this comment.
Any idea why adding unexported field triggered so many changes in msgp_gen?
Codecov Report
@@ Coverage Diff @@
## master #5041 +/- ##
==========================================
- Coverage 53.68% 52.44% -1.25%
==========================================
Files 432 432
Lines 54068 54069 +1
==========================================
- Hits 29029 28356 -673
- Misses 22793 23430 +637
- Partials 2246 2283 +37
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This was referenced Jan 23, 2023
This was referenced Jan 30, 2023
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In #4583 I tried to add a receivedAt proposal timing, following the pattern in #3703 for adding the validatedAt timing, but didn't correctly account for the receivedAt time needing to be attached to the
unauthenticatedProposalwhile the validatedAt time is attached to the validatedproposaltype. So the receivedAt timing when reported atensureActiontime was 0.The receivedAt and validatedAt timings are only used for telemetry reporting of performance information in the BlockAcceptedEventDetails message.
Test Plan
Added a test
TestPlayerRetainsReceivedValidatedAtto reproduce this behavior, then fixed it.