Skip to content

algocfg: Clarify config file loading error.#5025

Merged
algorandskiy merged 1 commit intoalgorand:masterfrom
winder:will/algocfg-errors
Jan 23, 2023
Merged

algocfg: Clarify config file loading error.#5025
algorandskiy merged 1 commit intoalgorand:masterfrom
winder:will/algocfg-errors

Conversation

@winder
Copy link
Copy Markdown
Contributor

@winder winder commented Jan 18, 2023

Summary

This error was being triggered by the new docker container. The working theory is that a newer config file is sometimes used with an older version of algocfg. This error message would clarify what is going wrong.

@winder winder self-assigned this Jan 18, 2023
@winder winder changed the title Clarify algocfg config file loading error. algocfg: Clarify config file loading error. Jan 18, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 18, 2023

Codecov Report

Merging #5025 (b9c8c8a) into master (4631571) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #5025      +/-   ##
==========================================
- Coverage   53.68%   53.67%   -0.02%     
==========================================
  Files         432      432              
  Lines       54068    54068              
==========================================
- Hits        29029    29019      -10     
- Misses      22793    22803      +10     
  Partials     2246     2246              
Impacted Files Coverage Δ
cmd/algocfg/getCommand.go 28.00% <0.00%> (ø)
cmd/algocfg/resetCommand.go 8.33% <0.00%> (ø)
cmd/algocfg/setCommand.go 8.19% <0.00%> (ø)
ledger/blockqueue.go 85.63% <0.00%> (-2.88%) ⬇️
catchup/service.go 69.32% <0.00%> (-1.21%) ⬇️
network/wsPeer.go 68.32% <0.00%> (-0.48%) ⬇️
ledger/testing/randomAccounts.go 56.26% <0.00%> (ø)
ledger/acctupdates.go 69.24% <0.00%> (+0.24%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@winder winder marked this pull request as ready for review January 19, 2023 18:24
@algorandskiy algorandskiy merged commit e0556e3 into algorand:master Jan 23, 2023
@winder winder deleted the will/algocfg-errors branch January 23, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants