Skip to content

util/s3: remove extra println#5024

Merged
algorandskiy merged 1 commit into
algorand:masterfrom
algolucky:fix/remove-println
Jan 19, 2023
Merged

util/s3: remove extra println#5024
algorandskiy merged 1 commit into
algorand:masterfrom
algolucky:fix/remove-println

Conversation

@algolucky
Copy link
Copy Markdown
Contributor

@algolucky algolucky commented Jan 18, 2023

Summary

@algolucky algolucky self-assigned this Jan 18, 2023
@algolucky algolucky marked this pull request as ready for review January 18, 2023 16:54
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 18, 2023

Codecov Report

Merging #5024 (3edfc1e) into master (eddf773) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5024      +/-   ##
==========================================
- Coverage   53.63%   53.63%   -0.01%     
==========================================
  Files         432      432              
  Lines       54057    54055       -2     
==========================================
- Hits        28996    28991       -5     
- Misses      22812    22818       +6     
+ Partials     2249     2246       -3     
Impacted Files Coverage Δ
util/s3/s3Helper.go 45.37% <ø> (-0.91%) ⬇️
ledger/blockqueue.go 85.63% <0.00%> (-2.88%) ⬇️
crypto/merkletrie/trie.go 66.42% <0.00%> (-2.19%) ⬇️
crypto/merkletrie/node.go 91.62% <0.00%> (-1.87%) ⬇️
cmd/tealdbg/debugger.go 72.69% <0.00%> (-0.81%) ⬇️
catchup/service.go 69.08% <0.00%> (-0.73%) ⬇️
ledger/acctupdates.go 69.24% <0.00%> (-0.25%) ⬇️
ledger/testing/randomAccounts.go 56.26% <0.00%> (ø)
network/wsNetwork.go 64.92% <0.00%> (+0.17%) ⬆️
catchup/peerSelector.go 100.00% <0.00%> (+1.04%) ⬆️
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@onetechnical
Copy link
Copy Markdown
Contributor

I believe updated versions do a tail instead, so curious if this is still necessary. Doesn't hurt anything, I don't think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants