Skip to content

Txhandler: Improve dedupe hit rate #5022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
algorandskiy merged 4 commits into from
Jan 23, 2023
Merged

Txhandler: Improve dedupe hit rate #5022

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aa37bb1
Improve txdedupe hitrate
iansuvak Jan 18, 2023
fdcf3bb
Properly return the hash and add a comment
iansuvak Jan 18, 2023
34db980
Move the check before the pageswap
iansuvak Jan 18, 2023
94a6f5b
Move inside else block to avoid redundant lookup
iansuvak Jan 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions data/txDupCache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,12 @@ func (c *txSaltedCache) CheckAndPut(msg []byte) (*crypto.Digest, bool) {
// already added to cache between RUnlock() and Lock(), return
return d, found
}
} else {
// Do another check to see if another copy of the transaction won the race to write it to the cache
// Only check current to save a lookup since swaps are rare and no need to re-hash
if _, found := c.cur[*d]; found {
return d, found
}
}

Comment thread
cce marked this conversation as resolved.
if len(c.cur) >= c.maxSize {
Expand Down