network: increase max incoming connections limit#5018
Merged
algorandskiy merged 2 commits intoJan 20, 2023
Conversation
gmalouf
reviewed
Jan 13, 2023
Contributor
gmalouf
left a comment
gmalouf
left a comment
There was a problem hiding this comment.
I'd like to see a change here paired with lowering the per host connection limit (perhaps to 10) - know that is under discussion.
Codecov Report
@@ Coverage Diff @@
## master #5018 +/- ##
==========================================
- Coverage 53.62% 53.62% -0.01%
==========================================
Files 432 432
Lines 54060 54060
==========================================
- Hits 28991 28990 -1
Misses 22824 22824
- Partials 2245 2246 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
gmalouf
previously approved these changes
Jan 13, 2023
gmalouf
approved these changes
Jan 13, 2023
gmalouf
approved these changes
Jan 19, 2023
cce
approved these changes
Jan 20, 2023
This was referenced Jan 23, 2023
This was referenced Jan 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
According to the latest measurement a single connection consumes about 1 MiB of RAM (calculated 600 KiB measured lower bound is 800 KiB, upper bound is 1.5 MiB).
Setting
IncomingConnectionsLimitto 2400 should have a total memory footprint of 3.6 GiB.Also decreased
MaxConnectionsPerIPto 15 as a best guess based on a fact only fraction of nodes report hitting this limit.Test Plan
Existing tests