AVM: Clearer cost benchmarks, and a nice optimization of b== and b<#5010
Merged
jannotti merged 3 commits intoalgorand:masterfrom Jan 12, 2023
Merged
AVM: Clearer cost benchmarks, and a nice optimization of b== and b<#5010jannotti merged 3 commits intoalgorand:masterfrom
jannotti merged 3 commits intoalgorand:masterfrom
Conversation
ahangsu
reviewed
Jan 12, 2023
Codecov Report
@@ Coverage Diff @@
## master #5010 +/- ##
==========================================
- Coverage 53.63% 53.62% -0.02%
==========================================
Files 432 432
Lines 54057 54060 +3
==========================================
- Hits 28996 28992 -4
- Misses 22812 22820 +8
+ Partials 2249 2248 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ahangsu
reviewed
Jan 12, 2023
ahangsu
reviewed
Jan 12, 2023
ahangsu
approved these changes
Jan 12, 2023
bbroder-algo
approved these changes
Jan 12, 2023
winder
pushed a commit
to winder/go-algorand
that referenced
this pull request
Jan 18, 2023
This was referenced Jan 23, 2023
This was referenced Jan 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up benchmarks in a way that should let us assign costs more easily, especially for costs that differ based on input size.
One such benchmark showed that "byte math compares" were all significantly improved by avoiding the use of big.Int, so that change is included.