CI: Fix PartitionTest Github Action#5006
Conversation
can we add some checks to ensure |
algobarb
left a comment
There was a problem hiding this comment.
The code changes relatively seems similar to what was in the PR summary, so I think the changes look good if they've been tested.
Added a fix to error out properly if it doesn't run: broke up the piped commands into two and added set -e and tested on the bugs we had here. It was updated without noticing because it failed silently (without failing the job) |
Codecov Report
@@ Coverage Diff @@
## master #5006 +/- ##
=======================================
Coverage 53.50% 53.51%
=======================================
Files 429 429
Lines 54038 54038
=======================================
+ Hits 28911 28916 +5
+ Misses 22883 22879 -4
+ Partials 2244 2243 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…lgorand into fixing-partitiontest-check
Fixing partitionTest linter to work:
go mod tidy -compat=1.17in cmd/partitiontest_linterTested locally and on github actions.