Tests: Fix t.Parallel() errors in shared package#4989
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4989 +/- ##
==========================================
- Coverage 53.63% 53.63% -0.01%
==========================================
Files 432 432
Lines 54057 54057
==========================================
- Hits 28996 28995 -1
- Misses 22812 22817 +5
+ Partials 2249 2245 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algochoi
approved these changes
Jan 11, 2023
Contributor
algochoi
left a comment
algochoi
left a comment
There was a problem hiding this comment.
There is only one test function that is being parallelized here, so the diff looks functionally equivalent to me. I'm okay with this change, but might be prudent for an extra approval.
cce
approved these changes
Jan 20, 2023
This was referenced Jan 23, 2023
This was referenced Jan 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables https://github.com/kunwardeep/paralleltest on
sharedby fixing linter warnings. Incrementally moves the ball towards greater unit test parallelization, which reduces local + CI test durations.I vetted for flakiness by running: