Test fix: flaky TestStreamVerifierCtxCancelPoolQueue#4980
Merged
algorandskiy merged 3 commits intoalgorand:masterfrom Jan 9, 2023
Merged
Test fix: flaky TestStreamVerifierCtxCancelPoolQueue#4980algorandskiy merged 3 commits intoalgorand:masterfrom
algorandskiy merged 3 commits intoalgorand:masterfrom
Conversation
…make sure the batch is rejected from the exec pool and not the batch ctx
Codecov Report
@@ Coverage Diff @@
## master #4980 +/- ##
==========================================
+ Coverage 53.67% 53.69% +0.02%
==========================================
Files 432 432
Lines 54077 54077
==========================================
+ Hits 29025 29036 +11
+ Misses 22806 22797 -9
+ Partials 2246 2244 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algorandskiy
approved these changes
Jan 9, 2023
winder
pushed a commit
to winder/go-algorand
that referenced
this pull request
Jan 18, 2023
This was referenced Jan 23, 2023
This was referenced Jan 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test expects to have the stream verifier shut down after the EnqueueBacklog returns an error.
To induce an error from EnqueueBacklog, the tests cancels the task ctx while the task is in the exec pool queue.
However, the task ctx canceled is the same as the stream verifier ctx, and occasionally, the stream verifier shuts down because of the ctx before it gets the change to enqueue the task to EnqueueBacklog. When this happens, the tests fails, because the expected message does not get logged.
To fix this, never shut down the stream verifier ctx, instead, shut down the verification pool ctx to make sure the batch is rejected from the exec pool and not the batch ctx.