tools: nodecfg without dns#4967
Merged
algorandskiy merged 4 commits intoalgorand:masterfrom Jan 6, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4967 +/- ##
=======================================
Coverage 53.67% 53.67%
=======================================
Files 432 432
Lines 54077 54077
=======================================
+ Hits 29025 29027 +2
+ Misses 22806 22801 -5
- Partials 2246 2249 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algolucky
approved these changes
Jan 6, 2023
algorandskiy
approved these changes
Jan 6, 2023
winder
pushed a commit
to winder/go-algorand
that referenced
this pull request
Jan 18, 2023
This was referenced Jan 23, 2023
This was referenced Jan 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It is possible to run a test cluster without dns, relying on phonebook.json instead. This makes test clusters slightly faster to set up and more reliable for not relying on the dns service.
Test Plan
This has been demonstrated manually in a test cluster.