Skip to content

cleanup: remove unused node.PoolStats()#4956

Merged
winder merged 2 commits into
algorand:masterfrom
brianolson:poolstats
Jan 4, 2023
Merged

cleanup: remove unused node.PoolStats()#4956
winder merged 2 commits into
algorand:masterfrom
brianolson:poolstats

Conversation

@brianolson
Copy link
Copy Markdown
Contributor

Summary

PoolStats() has been unused in the history of this repository. Remove it.

Test Plan

Code still builds and unit tests still pass.

@brianolson brianolson added tech debt Things that need re-work for simplification / sanitization to reduce implementation overhead Team Carbon-11 labels Jan 1, 2023
@brianolson brianolson self-assigned this Jan 1, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 1, 2023

Codecov Report

Merging #4956 (763180e) into master (35bcd35) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4956      +/-   ##
==========================================
- Coverage   53.74%   53.70%   -0.04%     
==========================================
  Files         433      433              
  Lines       54050    54040      -10     
==========================================
- Hits        29049    29024      -25     
- Misses      22759    22769      +10     
- Partials     2242     2247       +5     
Impacted Files Coverage Δ
daemon/algod/api/server/v2/test/helpers.go 75.34% <ø> (+0.51%) ⬆️
node/node.go 4.32% <ø> (+0.05%) ⬆️
ledger/tracker.go 74.26% <0.00%> (-4.65%) ⬇️
ledger/blockqueue.go 85.63% <0.00%> (-2.88%) ⬇️
crypto/merkletrie/trie.go 66.42% <0.00%> (-2.19%) ⬇️
crypto/merkletrie/node.go 91.62% <0.00%> (-1.87%) ⬇️
util/rateLimit.go 82.35% <0.00%> (-0.99%) ⬇️
network/wsNetwork.go 64.74% <0.00%> (-0.18%) ⬇️
network/wsPeer.go 68.32% <0.00%> (ø)
catchup/service.go 69.80% <0.00%> (ø)
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@brianolson brianolson marked this pull request as ready for review January 3, 2023 18:29
Copy link
Copy Markdown
Contributor

@jannotti jannotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Team Carbon-11 tech debt Things that need re-work for simplification / sanitization to reduce implementation overhead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants