tests: split TestResolver to enable more tests on CircleCI#4944
Merged
algorandskiy merged 3 commits intoalgorand:masterfrom Jan 3, 2023
Merged
tests: split TestResolver to enable more tests on CircleCI#4944algorandskiy merged 3 commits intoalgorand:masterfrom
algorandskiy merged 3 commits intoalgorand:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4944 +/- ##
==========================================
- Coverage 53.74% 53.69% -0.06%
==========================================
Files 433 433
Lines 54050 54050
==========================================
- Hits 29049 29020 -29
- Misses 22759 22780 +21
- Partials 2242 2250 +8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algorandskiy
reviewed
Jan 3, 2023
Contributor
algorandskiy
left a comment
algorandskiy
left a comment
There was a problem hiding this comment.
LGTM, please fix formatting
|
|
||
| import ( | ||
| "context" | ||
| "github.com/algorand/go-algorand/test/partitiontest" |
Contributor
Author
There was a problem hiding this comment.
@algorandskiy I attempted to fix in 2202e58.
algorandskiy
changed the title
algorandskiy
approved these changes
Jan 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits
TestResolverinto 3 tests in order to only disable Cloudflare-specific assertions on CircleCI. The PR enables broader CI test coverage while out-of-band Cloudflare DNS resolution investigation continues.