Tests: Switch e2e_basic_start_stop from devnet to private network#4942
Merged
algorandskiy merged 2 commits intoalgorand:masterfrom Dec 23, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4942 +/- ##
==========================================
+ Coverage 53.50% 53.51% +0.01%
==========================================
Files 432 432
Lines 53624 53624
==========================================
+ Hits 28691 28698 +7
+ Misses 22702 22700 -2
+ Partials 2231 2226 -5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algorandskiy
approved these changes
Dec 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends #4941 to switch
e2e_basic_start_stop.shnetwork from devnet to private network.Using a private network ameliorates a CircleCI-specific DNS connectivity issue. Additionally, we may wish to retain private network usage as a way to minimize dependencies for the basic start/stop sanity check.