Telemetry: Remove unused TelemetryOperation#4935
Merged
michaeldiamant merged 2 commits intoalgorand:masterfrom Jan 3, 2023
Merged
Telemetry: Remove unused TelemetryOperation#4935michaeldiamant merged 2 commits intoalgorand:masterfrom
michaeldiamant merged 2 commits intoalgorand:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4935 +/- ##
==========================================
- Coverage 53.74% 53.68% -0.06%
==========================================
Files 433 432 -1
Lines 54050 54031 -19
==========================================
- Hits 29049 29009 -40
- Misses 22759 22774 +15
- Partials 2242 2248 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
brianolson
previously approved these changes
Jan 3, 2023
Contributor
brianolson
left a comment
brianolson
left a comment
There was a problem hiding this comment.
Yes. There are better ways to do this. If we need it in the future we should build the right thing at that time.
excalq
previously approved these changes
Jan 3, 2023
Contributor
excalq
left a comment
excalq
left a comment
There was a problem hiding this comment.
The best programming language is red lines!
Thanks for doing a bit to clean up the hydra that is our telemetry code.
Contributor
Author
|
FYI - Merged in |
This was referenced Jan 23, 2023
This was referenced Jan 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposes removing what appears to be an unused telemetry functionality:
TelemetryOperation.Since I found no usage, I'm wondering if it's defunct functionality.