Skip to content

metrics: count telemetry server errors#4933

Merged
cce merged 1 commit intoalgorand:masterfrom
cce:count-telemetry-reporting-errors
Dec 22, 2022
Merged

metrics: count telemetry server errors#4933
cce merged 1 commit intoalgorand:masterfrom
cce:count-telemetry-reporting-errors

Conversation

@cce
Copy link
Copy Markdown
Contributor

@cce cce commented Dec 22, 2022

Summary

Following on #4932 this counts the number of telemetry reporting errors observed by the telemetry hook.

Test Plan

Existing tests should pass.

@cce cce force-pushed the count-telemetry-reporting-errors branch from 4b7bae2 to ae8610c Compare December 22, 2022 15:44
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 22, 2022

Codecov Report

Merging #4933 (ae8610c) into master (1313a7b) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #4933      +/-   ##
==========================================
- Coverage   53.51%   53.50%   -0.02%     
==========================================
  Files         432      432              
  Lines       53623    53624       +1     
==========================================
- Hits        28698    28693       -5     
- Misses      22699    22701       +2     
- Partials     2226     2230       +4     
Impacted Files Coverage Δ
logging/telemetryhook.go 50.70% <0.00%> (-0.36%) ⬇️
ledger/roundlru.go 90.56% <0.00%> (-5.67%) ⬇️
network/wsPeer.go 67.06% <0.00%> (-2.39%) ⬇️
crypto/merkletrie/trie.go 66.42% <0.00%> (-2.19%) ⬇️
crypto/merkletrie/node.go 91.62% <0.00%> (-1.87%) ⬇️
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) ⬇️
data/transactions/verify/txn.go 73.72% <0.00%> (-0.85%) ⬇️
catchup/service.go 69.08% <0.00%> (-0.25%) ⬇️
network/wsNetwork.go 64.92% <0.00%> (+0.17%) ⬆️
ledger/acctupdates.go 69.24% <0.00%> (+0.36%) ⬆️
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cce cce merged commit 1393764 into algorand:master Dec 22, 2022
@cce cce deleted the count-telemetry-reporting-errors branch December 22, 2022 17:55
algobarb pushed a commit to algobarb/go-algorand that referenced this pull request Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants