CICD: add container build#4927
Merged
algorandskiy merged 34 commits intomasterfrom Jan 6, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4927 +/- ##
==========================================
- Coverage 53.54% 53.52% -0.03%
==========================================
Files 431 431
Lines 53533 53533
==========================================
- Hits 28662 28651 -11
- Misses 22644 22656 +12
+ Partials 2227 2226 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algobarb
previously approved these changes
Jan 4, 2023
algojack
reviewed
Jan 4, 2023
algojack
reviewed
Jan 4, 2023
excalq
reviewed
Jan 4, 2023
algojack
approved these changes
Jan 4, 2023
algobarb
approved these changes
Jan 6, 2023
winder
reviewed
Jan 6, 2023
winder
reviewed
Jan 6, 2023
winder
reviewed
Jan 6, 2023
winder
reviewed
Jan 6, 2023
winder
approved these changes
Jan 6, 2023
Contributor
winder
left a comment
There was a problem hiding this comment.
Changes look great. Mainly just had some questions / minor suggestions.
Contributor
Author
|
thank you @winder for the suggestions, I'd like to address your comments in a fast-follow PR. they are all valid. |
This was referenced Jan 8, 2023
winder
pushed a commit
to winder/go-algorand
that referenced
this pull request
Jan 18, 2023
This was referenced Jan 23, 2023
This was referenced Jan 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a GitHub Actions container workflow and other updates.
Supported Platforms
Image Sizes
Tags
Notable Changes
./scripts/dev_install.sh.make buildthis was another build.deveven when building other branches likerel/stable.dataTemplate. the functionality was replaced by instead copying config.json.example to the correct location inrun.shinstart_new_public_networkubuntu:18.04instead ofgolang:$GO_VERSION-slimalgoranduser inside the container.pythonandgit-corefrom the installation step in the builder.--install-no-recommendsto allapt-get install -yinvocations.install.shto remove artifacts that are not required.Test Plan