tests: fix dependency on global counters#4921
Merged
algorandskiy merged 7 commits intoalgorand:masterfrom Dec 17, 2022
Merged
Conversation
algonautshant
force-pushed
the
shant/multisig_benchmark
branch
from
cbc7c2a to
d4bf6e0
Compare
algorandskiy
changed the title
algorandskiy
previously approved these changes
Dec 17, 2022
Codecov Report
@@ Coverage Diff @@
## master #4921 +/- ##
==========================================
- Coverage 53.55% 53.53% -0.02%
==========================================
Files 431 431
Lines 53533 53533
==========================================
- Hits 28667 28660 -7
- Misses 22643 22648 +5
- Partials 2223 2225 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algorandskiy
approved these changes
Dec 17, 2022
This was referenced Jan 23, 2023
This was referenced Jan 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests depend on global counters. Depending on the order of the tests running, they might interfere with each other, or interfere with parallel running tests.
This change forces such tests not to run in parallel, and initializes and resets the global counters.
In addition, cleanup of resources (ledger close, exec pool shutdown) which are not returned when the tests finish and consume memory and threads unnecessarily.