rest api: update WaitForBlock summary#4910
Merged
Merged
Conversation
winder
previously approved these changes
Dec 14, 2022
ab09f27 to
7d6c3fc
Compare
Codecov Report
@@ Coverage Diff @@
## master #4910 +/- ##
==========================================
+ Coverage 54.08% 54.11% +0.03%
==========================================
Files 427 427
Lines 53528 53528
==========================================
+ Hits 28948 28965 +17
+ Misses 22314 22300 -14
+ Partials 2266 2263 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
barnjamin
approved these changes
Dec 15, 2022
This was referenced Jan 23, 2023
This was referenced Jan 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WaitForBlock waits for r+1 so updated the method summary.
Resolves https://github.com/algorand/go-algorand-internal/issues/1361
Test Plan
Existing tests