Skip to content

tests: fix flaky TestTxHandlerRememberReportErrorsWithTxPool#4905

Merged
michaeldiamant merged 1 commit intoalgorand:masterfrom
algorandskiy:pavel/txhandler-test-fix
Dec 14, 2022
Merged

tests: fix flaky TestTxHandlerRememberReportErrorsWithTxPool#4905
michaeldiamant merged 1 commit intoalgorand:masterfrom
algorandskiy:pavel/txhandler-test-fix

Conversation

@algorandskiy
Copy link
Copy Markdown
Contributor

Summary

Sometimes on CI block listener is not triggered or triggered before the waiter. Fixed by

  1. adding more than one blocks
  2. having a waiting timeout

Test Plan

This is a test fix.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 14, 2022

Codecov Report

Merging #4905 (e3f8776) into master (bd64ce8) will increase coverage by 0.51%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4905      +/-   ##
==========================================
+ Coverage   54.08%   54.59%   +0.51%     
==========================================
  Files         427      431       +4     
  Lines       53528    53568      +40     
==========================================
+ Hits        28948    29246     +298     
+ Misses      22314    22028     -286     
- Partials     2266     2294      +28     
Impacted Files Coverage Δ
cmd/tealdbg/debugger.go 72.69% <0.00%> (-0.81%) ⬇️
network/wsNetwork.go 64.92% <0.00%> (ø)
util/tcpinfo_darwin.go 0.00% <0.00%> (ø)
util/db/fullfsync_darwin.go 100.00% <0.00%> (ø)
util/sleep.go 0.00% <0.00%> (ø)
libgoal/lockedFileUnix.go 0.00% <0.00%> (ø)
data/transactions/logic/eval.go 90.19% <0.00%> (+0.03%) ⬆️
agreement/player.go 96.61% <0.00%> (+0.28%) ⬆️
crypto/merkletrie/cache.go 89.02% <0.00%> (+0.29%) ⬆️
data/bookkeeping/block.go 56.61% <0.00%> (+0.33%) ⬆️
... and 20 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Copy Markdown
Contributor

@michaeldiamant michaeldiamant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The full build passes - https://app.circleci.com/pipelines/github/algorand/go-algorand/11231/workflows/c14d5d85-bf60-4979-92b1-54f651eadc93.

I admit I'm not intimately familiar with the PR's changes. However, it only changes tests and so I think it's reasonable to merge.

@michaeldiamant michaeldiamant merged commit ee27bc7 into algorand:master Dec 14, 2022
@algorandskiy algorandskiy deleted the pavel/txhandler-test-fix branch March 16, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants