tests: fix flaky TestTxHandlerRememberReportErrorsWithTxPool#4905
Merged
michaeldiamant merged 1 commit intoalgorand:masterfrom Dec 14, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4905 +/- ##
==========================================
+ Coverage 54.08% 54.59% +0.51%
==========================================
Files 427 431 +4
Lines 53528 53568 +40
==========================================
+ Hits 28948 29246 +298
+ Misses 22314 22028 -286
- Partials 2266 2294 +28
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
michaeldiamant
approved these changes
Dec 14, 2022
Contributor
michaeldiamant
left a comment
There was a problem hiding this comment.
The full build passes - https://app.circleci.com/pipelines/github/algorand/go-algorand/11231/workflows/c14d5d85-bf60-4979-92b1-54f651eadc93.
I admit I'm not intimately familiar with the PR's changes. However, it only changes tests and so I think it's reasonable to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sometimes on CI block listener is not triggered or triggered before the waiter. Fixed by
Test Plan
This is a test fix.