Skip to content

API: Make the data endpoints public.#4900

Merged
algorandskiy merged 1 commit intoalgorand:masterfrom
winder:will/public-sync-endpoints
Dec 13, 2022
Merged

API: Make the data endpoints public.#4900
algorandskiy merged 1 commit intoalgorand:masterfrom
winder:will/public-sync-endpoints

Conversation

@winder
Copy link
Copy Markdown
Contributor

@winder winder commented Dec 13, 2022

Summary

We want the data endpoints to be available in the SDKs, so they are being marked "public". This means the regular API token will be able to use these endpoints when they are enabled. Node API providers, Relays and participation nodes would not have this enabled, so there should be no security concern.

Test Plan

N/A

@winder winder requested a review from Eric-Warehime December 13, 2022 17:45
@winder winder marked this pull request as ready for review December 13, 2022 17:46
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 13, 2022

Codecov Report

Merging #4900 (5a23249) into master (80476a7) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4900      +/-   ##
==========================================
- Coverage   54.05%   54.05%   -0.01%     
==========================================
  Files         427      427              
  Lines       53520    53520              
==========================================
- Hits        28930    28928       -2     
  Misses      22319    22319              
- Partials     2271     2273       +2     
Impacted Files Coverage Δ
ledger/voters.go 68.65% <0.00%> (-4.48%) ⬇️
ledger/tracker.go 74.26% <0.00%> (-3.80%) ⬇️
ledger/acctonline.go 77.77% <0.00%> (-0.52%) ⬇️
network/wsNetwork.go 64.74% <0.00%> (-0.18%) ⬇️
ledger/testing/randomAccounts.go 56.61% <0.00%> (ø)
catchup/service.go 69.32% <0.00%> (+0.24%) ⬆️
network/wsPeer.go 69.68% <0.00%> (+0.71%) ⬆️
ledger/acctupdates.go 69.72% <0.00%> (+0.72%) ⬆️
cmd/tealdbg/debugger.go 73.49% <0.00%> (+0.80%) ⬆️
catchup/peerSelector.go 100.00% <0.00%> (+1.04%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@algorandskiy algorandskiy merged commit 65a6939 into algorand:master Dec 13, 2022
@winder winder deleted the will/public-sync-endpoints branch December 13, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants