API: Make the data endpoints public.#4900
Merged
algorandskiy merged 1 commit intoalgorand:masterfrom Dec 13, 2022
Merged
Conversation
Eric-Warehime
approved these changes
Dec 13, 2022
Codecov Report
@@ Coverage Diff @@
## master #4900 +/- ##
==========================================
- Coverage 54.05% 54.05% -0.01%
==========================================
Files 427 427
Lines 53520 53520
==========================================
- Hits 28930 28928 -2
Misses 22319 22319
- Partials 2271 2273 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algorandskiy
approved these changes
Dec 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We want the data endpoints to be available in the SDKs, so they are being marked "public". This means the regular API token will be able to use these endpoints when they are enabled. Node API providers, Relays and participation nodes would not have this enabled, so there should be no security concern.
Test Plan
N/A