metrics: split alive check counter between early/dead#4898
Merged
Conversation
algorandskiy
previously approved these changes
Dec 13, 2022
iansuvak
approved these changes
Dec 13, 2022
Codecov Report
@@ Coverage Diff @@
## master #4898 +/- ##
==========================================
- Coverage 54.06% 54.04% -0.03%
==========================================
Files 427 427
Lines 53520 53528 +8
==========================================
- Hits 28935 28927 -8
- Misses 22316 22329 +13
- Partials 2269 2272 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algorandskiy
approved these changes
Dec 13, 2022
This was referenced Dec 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This splits the "dead" txhandler counters between "early" and "dead" to track them separately.
Test Plan
Update existing counter tests.