Skip to content

testing: defi txn group benchmark#4886

Merged
algorandskiy merged 4 commits intoalgorand:masterfrom
algorandskiy:tinyman-bench
Dec 12, 2022
Merged

testing: defi txn group benchmark#4886
algorandskiy merged 4 commits intoalgorand:masterfrom
algorandskiy:tinyman-bench

Conversation

@algorandskiy
Copy link
Copy Markdown
Contributor

Summary

Add a relatively large txn group benchmark with seen in the wild data

Test Plan

TODO: plug into txHandler testing infrastructure

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 10, 2022

Codecov Report

Merging #4886 (a64255c) into master (c0e044b) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4886      +/-   ##
==========================================
+ Coverage   54.06%   54.09%   +0.03%     
==========================================
  Files         427      427              
  Lines       53474    53474              
==========================================
+ Hits        28909    28928      +19     
+ Misses      22299    22286      -13     
+ Partials     2266     2260       -6     
Impacted Files Coverage Δ
network/wsPeer.go 69.45% <0.00%> (-2.39%) ⬇️
network/wsNetwork.go 64.74% <0.00%> (-0.18%) ⬇️
ledger/testing/randomAccounts.go 56.61% <0.00%> (ø)
data/transactions/logic/assembler.go 86.50% <0.00%> (+0.13%) ⬆️
ledger/acctupdates.go 69.24% <0.00%> (+0.24%) ⬆️
ledger/acctonline.go 78.81% <0.00%> (+0.51%) ⬆️
ledger/tracker.go 75.94% <0.00%> (+0.84%) ⬆️
catchup/service.go 71.25% <0.00%> (+1.44%) ⬆️
crypto/merkletrie/node.go 93.48% <0.00%> (+1.86%) ⬆️
agreement/proposalManager.go 98.03% <0.00%> (+1.96%) ⬆️
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

algonautshant
algonautshant previously approved these changes Dec 10, 2022
Copy link
Copy Markdown
Contributor

@algonautshant algonautshant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.
Will be nice to add a description comments for each stage of the benchmark.
It is not straightforward what each one it evaluationg.
e.g.

  1. Checks the lsig signature crypto only
  2. Checks the sig crypto of 0 and 2, and the logic of 1 and 3
  3. Checks the sig and lsig signature crypto only

Comment thread data/transactions/verify/artifact_test.go Outdated
Co-authored-by: Shant Karakashian <55754073+algonautshant@users.noreply.github.com>
@algorandskiy algorandskiy merged commit fb95de1 into algorand:master Dec 12, 2022
@algorandskiy algorandskiy deleted the tinyman-bench branch March 16, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants