Catchpoint: Promote trie-related log warnings to error#4882
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4882 +/- ##
=======================================
Coverage 54.06% 54.06%
=======================================
Files 427 427
Lines 53520 53520
=======================================
+ Hits 28934 28938 +4
+ Misses 22319 22316 -3
+ Partials 2267 2266 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cce
approved these changes
Dec 9, 2022
cce
reviewed
Dec 9, 2022
| root, rootErr := ct.balancesTrie.RootHash() | ||
| if rootErr != nil { | ||
| ct.log.Infof("accountsUpdateBalances: error retrieving balances trie root: %v", rootErr) | ||
| ct.log.Errorf("accountsUpdateBalances: error retrieving balances trie root: %v", rootErr) |
Contributor
There was a problem hiding this comment.
this one doesn't seem as serious.. not related to any major data invariant being broken
Contributor
Author
There was a problem hiding this comment.
@cce I agree it's not as serious. If you feel strongly, I can open a new PR to revert the log level change - let me know?
I felt a failure here likely implies an issue with how the software is written rather than how it's used.
This was referenced Dec 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promotes log levels from warning to error for failed
balancesTriemodifications. Since we've previously noted concerns here, the rationale is:If we accept the PR, I suspect there are other places we'll want a similar change. The PR makes no attempt to scan beyond
accountsUpdateBalances.Test Plan
Existing tests pass.