Skip to content

algod: Remove unused generated code#4880

Merged
michaeldiamant merged 1 commit intoalgorand:masterfrom
Eric-Warehime:remove-unused-generated-code
Dec 9, 2022
Merged

algod: Remove unused generated code#4880
michaeldiamant merged 1 commit intoalgorand:masterfrom
Eric-Warehime:remove-unused-generated-code

Conversation

@Eric-Warehime
Copy link
Copy Markdown
Contributor

Summary

This code is leftover from #4714 and is no longer used, needed or maintained.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 8, 2022

Codecov Report

Merging #4880 (6b93c9f) into master (93c01b5) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4880   +/-   ##
=======================================
  Coverage   54.03%   54.04%           
=======================================
  Files         427      427           
  Lines       53474    53474           
=======================================
+ Hits        28897    28901    +4     
+ Misses      22312    22310    -2     
+ Partials     2265     2263    -2     
Impacted Files Coverage Δ
ledger/blockqueue.go 85.63% <0.00%> (-1.73%) ⬇️
catchup/service.go 68.59% <0.00%> (-0.73%) ⬇️
ledger/testing/randomAccounts.go 57.23% <0.00%> (+0.61%) ⬆️
network/wsPeer.go 68.97% <0.00%> (+1.90%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Copy Markdown
Contributor

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@michaeldiamant michaeldiamant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice diff - 0 lines added and > 1,000 lines removed!

@michaeldiamant michaeldiamant merged commit 58a1532 into algorand:master Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants