Skip to content

metrics: fix TestGetValue#4879

Merged
algorandskiy merged 1 commit intoalgorand:masterfrom
algorandskiy:pavel/metrics-fix
Dec 8, 2022
Merged

metrics: fix TestGetValue#4879
algorandskiy merged 1 commit intoalgorand:masterfrom
algorandskiy:pavel/metrics-fix

Conversation

@algorandskiy
Copy link
Copy Markdown
Contributor

Summary

TestGetValue registers a new metric that breaks other tests expectations on number of metrics. This might not be caught be CI because of sharding.

Test Plan

This is a test fix.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 8, 2022

Codecov Report

Merging #4879 (805770b) into master (c0e044b) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4879      +/-   ##
==========================================
- Coverage   54.06%   54.05%   -0.01%     
==========================================
  Files         427      427              
  Lines       53474    53474              
==========================================
- Hits        28909    28905       -4     
- Misses      22299    22303       +4     
  Partials     2266     2266              
Impacted Files Coverage Δ
network/wsPeer.go 68.97% <0.00%> (-2.87%) ⬇️
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) ⬇️
ledger/testing/randomAccounts.go 56.00% <0.00%> (-0.62%) ⬇️
data/transactions/logic/assembler.go 86.50% <0.00%> (+0.13%) ⬆️
ledger/acctupdates.go 69.24% <0.00%> (+0.24%) ⬆️
catchup/service.go 70.04% <0.00%> (+0.24%) ⬆️
crypto/merkletrie/node.go 93.48% <0.00%> (+1.86%) ⬆️
crypto/merkletrie/trie.go 68.61% <0.00%> (+2.18%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@algorandskiy algorandskiy merged commit 93c01b5 into algorand:master Dec 8, 2022
@algorandskiy algorandskiy deleted the pavel/metrics-fix branch March 16, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants