algod: Delete deprecated cost field in dyrun response and mapping field in sourcemap

cmd/goal/clerk.go

@@ -1229,9 +1229,6 @@ var dryrunRemoteCmd = &cobra.Command{
 						trace = *txnResult.LogicSigTrace
 					}
 				}
-				if txnResult.Cost != nil {
-					fmt.Fprintf(os.Stdout, "tx[%d] cost: %d\n", i, *txnResult.Cost)
-				}
 				if txnResult.BudgetConsumed != nil {
 					fmt.Fprintf(os.Stdout, "tx[%d] budget consumed: %d\n", i, *txnResult.BudgetConsumed)
 				}

daemon/algod/api/algod.oas2.json

@@ -3223,10 +3223,6 @@
         "budget-consumed": {
           "description": "Budget consumed during execution of app call transaction.",
           "type": "integer"
-        },
-        "cost": {
-          "description": "Net cost of app execution. Field is DEPRECATED and is subject for removal. Instead, use `budget-added` and `budget-consumed.",
-          "type": "integer"
         }
       }
     },

daemon/algod/api/algod.oas3.yml

@@ -1634,10 +1634,6 @@
             "description": "Budget consumed during execution of app call transaction.",
             "type": "integer"
           },
-          "cost": {
-            "description": "Net cost of app execution. Field is DEPRECATED and is subject for removal. Instead, use `budget-added` and `budget-consumed.",
-            "type": "integer"
-          },
           "disassembly": {
             "description": "Disassembled program line by line.",
             "items": {

daemon/algod/api/server/v2/dryrun.go

@@ -554,11 +554,8 @@ func doDryrunRequest(dr *DryrunRequest, response *model.DryrunResponse) {
 				// This is necessary because the fields can only be represented as unsigned
 				// integers, so a negative cost would underflow. The two fields also provide
 				// more information, which can be useful for testing purposes.
-				// cost = budgetConsumed - budgetAdded
-				netCost := uint64(cost)
 				budgetAdded := uint64(proto.MaxAppProgramCost * numInnerTxns(delta))
 				budgetConsumed := uint64(cost) + budgetAdded
-				result.Cost = &netCost
 				result.BudgetAdded = &budgetAdded
 				result.BudgetConsumed = &budgetConsumed
 				maxCurrentBudget = pooledAppBudget

data/transactions/logic/sourcemap.go

@@ -36,9 +36,7 @@ type SourceMap struct {
 	SourceRoot string   `json:"sourceRoot,omitempty"`
 	Sources    []string `json:"sources"`
 	Names      []string `json:"names"`
-	// Mapping field is deprecated. Use `Mappings` field instead.
-	Mapping  string `json:"mapping"`
-	Mappings string `json:"mappings"`
+	Mappings   string   `json:"mappings"`
 }
 
 // GetSourceMap returns a struct containing details about
@@ -64,11 +62,9 @@ func GetSourceMap(sourceNames []string, offsetToLine map[int]int) SourceMap {
 	}
 
 	return SourceMap{
-		Version: sourceMapVersion,
-		Sources: sourceNames,
-		Names:   []string{}, // TEAL code does not generate any names.
-		// Mapping is deprecated, and only for backwards compatibility.
-		Mapping:  strings.Join(pcToLine, ";"),
+		Version:  sourceMapVersion,
+		Sources:  sourceNames,
+		Names:    []string{}, // TEAL code does not generate any names.
 		Mappings: strings.Join(pcToLine, ";"),
 	}
 }