tests: skip flaky node tests#4862
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4862 +/- ##
==========================================
- Coverage 54.03% 54.03% -0.01%
==========================================
Files 427 427
Lines 53474 53474
==========================================
- Hits 28897 28896 -1
- Misses 22312 22313 +1
Partials 2265 2265
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I suggest to disable them back and make another approach later |
These tests have been disabled since the initial commit of the project https://github.com/algorand/go-algorand/blame/381a8352020d2a043631944b3fe58e3c76e377dc/node/node_test.go#L181 I'm fine with disabling them if you want, but unless I personally get time to look at them it doesn't seem like anyone else is going to. Also, I think having tests here that don't run gives somewhat of a false sense of having coverage where you don't (even though the coverage report reflects that they don't run). |
|
I suggest we set a timeline for deleting these tests. In 6 months, if we cannot collaboratively resolve the issues, then we delete them. First, please add to this PR the information about the failures of the tests, and let the reviewers evaluate why they are failing. |
|
Test failures can be seen in nightly tests https://app.circleci.com/pipelines/github/algorand/go-algorand/10983/workflows/c9fcb7ba-7be3-4217-80e4-ae8b5baa0a9b/jobs/188091 |
ad68e79 to
abaf0d8
Compare
Summary
#4824 Re-enabled 3 tests in
node_tests.gowhich have since caused nightly build failures every night. I've gone ahead and deleted the two tests I see failing every night--they haven't actually been run for years, and some of this code dates back to the original commit.