Catchpoint: Fix broken merge between #4818 and #4835#4840
Merged
michaeldiamant merged 1 commit intoalgorand:masterfrom Nov 30, 2022
Merged
Catchpoint: Fix broken merge between #4818 and #4835#4840michaeldiamant merged 1 commit intoalgorand:masterfrom
michaeldiamant merged 1 commit intoalgorand:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4840 +/- ##
==========================================
+ Coverage 53.52% 53.56% +0.03%
==========================================
Files 422 422
Lines 53852 53852
==========================================
+ Hits 28826 28845 +19
+ Misses 22704 22685 -19
Partials 2322 2322
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bbroder-algo
approved these changes
Nov 30, 2022
This was referenced Dec 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes broken merge between #4818 and #4835.
Prior to the PR,
masterfails compilation with:ledger/catchpointwriter_test.go:585:22: undefined: MakeMerkleCommitter.