Merged
Conversation
derbear
previously approved these changes
Jun 18, 2019
Contributor
derbear
left a comment
derbear
left a comment
There was a problem hiding this comment.
I think logs will also hold information such as any addresses you're participating with, which is a good thing to note if you're going to send them to a developer. Maybe the user would like to scrub them first.
derbear
reviewed
Jun 18, 2019
Contributor
|
Actually, one feature that I like is that if i just have one git commit, GitHub automatically populates the fields with my git commit message text before merging. How does this feature interact with that one? |
…'t want that information to be shared with Algorand.
Contributor
Author
|
@derbear I'm not sure, hopefully it will continue to work that way because I didn't include any header fields in the PR template (like I did with the issues) |
zeldovich
reviewed
Jun 18, 2019
derbear
approved these changes
Jun 18, 2019
derbear
pushed a commit
to derbear/go-algorand
that referenced
this pull request
Apr 23, 2020
Debugger improvements
algorandskiy
pushed a commit
to algorandskiy/go-algorand
that referenced
this pull request
Dec 6, 2021
…int-dump Test for resource data conversion and minor code fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pull requests and issues have inconsistent formats which could lead to improper use or missing information.
Test Plan
After this is merged in I'll check that they work.