goal: account deletepartkey subcomand#4788
Merged
Merged
Conversation
AlgoStephenAkiki
changed the title
AlgoStephenAkiki
force-pushed
the
3796-new-goal-account-deletepartkey-subcommand
branch
from
73f74aa to
44bf852
Compare
Codecov Report
@@ Coverage Diff @@
## master #4788 +/- ##
==========================================
+ Coverage 53.31% 53.34% +0.02%
==========================================
Files 423 423
Lines 53852 53865 +13
==========================================
+ Hits 28713 28732 +19
Misses 22854 22854
+ Partials 2285 2279 -6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Eric-Warehime
previously approved these changes
Nov 15, 2022
winder
reviewed
Nov 15, 2022
winder
reviewed
Nov 15, 2022
winder
suggested changes
Nov 18, 2022
Contributor
winder
left a comment
winder
left a comment
There was a problem hiding this comment.
In addition to the suggestions, please add a test.
Eric-Warehime
previously approved these changes
Nov 30, 2022
Resolves #3796 Adds delete part keys helper function
AlgoStephenAkiki
force-pushed
the
3796-new-goal-account-deletepartkey-subcommand
branch
from
3405a13 to
2a5315c
Compare
winder
changed the title
winder
approved these changes
Dec 7, 2022
This was referenced Dec 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #3796
Adds delete part keys helper function
Test Plan
New integration test.