tests: Fix resolver test endpoint#4784
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4784 +/- ##
==========================================
- Coverage 54.71% 54.69% -0.03%
==========================================
Files 414 414
Lines 53548 53548
==========================================
- Hits 29299 29287 -12
- Misses 21825 21834 +9
- Partials 2424 2427 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
winder
approved these changes
Nov 14, 2022
onetechnical
approved these changes
Nov 14, 2022
Contributor
onetechnical
left a comment
There was a problem hiding this comment.
I'm fine with this, but it does mean our tests are dependent on DevNet's DNS records. That's not the worst thing, but is a point of failure (and we do reserve the right to "reset" DevNet, during which time this will fail these checks.)
This was referenced Nov 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolver_test.gois failing because gmail's jabber SRV records seem not to exist anymore. I've updated the test to point to our own telemetry SRV records for devnet.Test Plan
Unit test passes.