algod: Delete v1 usage from client and remove V2 prefix from APIs#4767
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4767 +/- ##
==========================================
+ Coverage 54.59% 54.68% +0.09%
==========================================
Files 414 414
Lines 53646 53548 -98
==========================================
- Hits 29286 29282 -4
+ Misses 21935 21837 -98
- Partials 2425 2429 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
michaeldiamant
approved these changes
Nov 8, 2022
Contributor
michaeldiamant
left a comment
There was a problem hiding this comment.
@algochoi Thanks for splitting out a separate PR for v1 removals + final renames.
This was referenced Nov 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes
TransactionByAddr.The PR also removes the
V2prefix from client APIs, since we do not have to distinguish between v1 and v2 algod APIs.Test Plan
CI Tests.