goal: Change asset commands to use AccountAssetInformation#4758
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4758 +/- ##
==========================================
- Coverage 54.56% 54.19% -0.38%
==========================================
Files 414 414
Lines 53666 53646 -20
==========================================
- Hits 29283 29073 -210
- Misses 21955 22115 +160
- Partials 2428 2458 +30
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jasonpaulos
reviewed
Nov 7, 2022
Contributor
jasonpaulos
left a comment
jasonpaulos
left a comment
There was a problem hiding this comment.
Thanks for taking the time to make these improvements.
I left a suggestion for some additional code simplification, but consider it optional.
jasonpaulos
previously approved these changes
Nov 7, 2022
michaeldiamant
approved these changes
Nov 7, 2022
Contributor
|
Merging - I reviewed the backward incompatible API change and agree with categorizing it as a bug fix. |
This was referenced Nov 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses some open comments made in #4684
Addresses three things:
EncodedBlockCertdecoding to useDecodeinstead ofDecodeReflectAccountAssetInformationAPI ingoal asset info. This changes behavior ingoal asset infothat looked like a bug regarding reserve addresses: the command now returns an error if a reserve asset is not opted into the asset, whereas previously, the command returned zero-ed values without failing. One test was changed to reflect this behavior.libgoalto useAccountAssetInformationinstead ofAccountInformationV2Test Plan
CI tests.