tests: Fix account tests for calling pending txn endpoint and box tests#4751
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4751 +/- ##
==========================================
+ Coverage 54.53% 54.56% +0.03%
==========================================
Files 414 414
Lines 53607 53607
==========================================
+ Hits 29234 29253 +19
+ Misses 21945 21929 -16
+ Partials 2428 2425 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
michaeldiamant
left a comment
There was a problem hiding this comment.
@algochoi Thanks for the fix - Merging now to address failed build: https://app.circleci.com/pipelines/github/algorand/go-algorand/10341/workflows/c4dac869-0f91-4ce1-8b7d-abd0e5e63ea9.
@jasonpaulos I request that you still perform a review to identify pending threads.
jasonpaulos
left a comment
There was a problem hiding this comment.
Changes look good to me
|
@algochoi @michaeldiamant looks like there is another one in e2e subs box-search.sh: |
|
@algorandskiy that failure was addressed by the change to |
Summary
This PR changes some existing tests that call the GetPendingTransactions endpoint to use the v2 model instead of the v1 model. Also changes the
goal boxcommand to account for client-side error string handling.Test Plan
Integration tests.