StateProofs: Use stateproof tracker#4733
Conversation
id-ms
force-pushed
the
use-stateproof-tracker
branch
from
0b2f2d2 to
e6479b8
Compare
Codecov Report
@@ Coverage Diff @@
## feature/stateproofs-recoverability #4733 +/- ##
======================================================================
- Coverage 54.69% 54.68% -0.01%
======================================================================
Files 415 415
Lines 53783 53805 +22
======================================================================
+ Hits 29415 29424 +9
- Misses 21916 21933 +17
+ Partials 2452 2448 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
|
||
| func getDefaultStateProofConsensusParams() config.ConsensusParams { | ||
| consensusParams := config.Consensus[protocol.ConsensusCurrentVersion] | ||
| consensusParams := config.Consensus[protocol.ConsensusFuture] |
There was a problem hiding this comment.
We should remember to change this after the consensus upgrade. Maybe add a ticket?
almog-t
left a comment
almog-t
left a comment
There was a problem hiding this comment.
Good work, not a lot we can or should change.
| } | ||
|
|
||
| var verificationData *ledgercore.StateProofVerificationData | ||
| if config.Consensus[atRoundHdr.CurrentProtocol].StateProofUseTrackerVerification { |
There was a problem hiding this comment.
Do you think we should cover the verification method switch with a test?
There was a problem hiding this comment.
There are two tests -
1 TestCowStateProof check the old code - verification using blockheader
2 TestCowStateProofV34 - using the tracker.
algorandskiy
left a comment
algorandskiy
left a comment
There was a problem hiding this comment.
Looks reasonable, and it looks like a time to review the entire change
| err := apply.StateProof(stateProofTx, atRound, c0, validate) | ||
| require.ErrorIs(t, err, apply.ErrStateProofTypeNotSupported) | ||
|
|
||
| // 100% coverage |
There was a problem hiding this comment.
no more 100% coverage?
There was a problem hiding this comment.
just thought that the comments doesn't help much :)
If you think there is an edge case that we didn't cover, I will happily test it
3 participants
Summary
Test Plan